LibWeb: Add CompressionStream/DecompressionStream #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdahlin
force-pushed
the
compression-stream
branch
7 times, most recently
from
b2f010b
to
629ae46
Compare
TODO: Figure out how to make JS APIs private TODO: Bundle JS inside the executable TODO: Create a proper test case TODO: Figure out how to run WPT
jdahlin
force-pushed
the
compression-stream
branch
from
629ae46
to
d59b0ed
Compare
jdahlin
force-pushed
the
compression-stream
branch
from
d59b0ed
to
0459795
Compare
rmg-x
reviewed
Oct 4, 2024
| // "Note: Some non-conformant implementations send the "deflate" | ||
| // compressed data without the zlib wrapper." | ||
| return DeflateDecompressor::decompress_all(bytes); | ||
| } else { |
There was a problem hiding this comment.
The else block here is unnecessary and I believe the linter usually complains when it sees that but I don't remember.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibWeb: Add CompressionStream/DecompressionStream
This PR implements CompressionStream and DecompressionStream. A basic example is included that has also been tested in Brave.
The new APIs are implemented on top of TransformStream using JavaScript, it's still a draft and I'd like to get some input on the general approach before I finish it up.
At the very least, a proper test needs to be added and some way to embed the JS source inside the executable, probably via some kind of generator script. It would also be good to figure out how to make the APIs internal, currently CompressionStream_constructor is exposed in the public JS API which would be good to avoid, unsure if it's a blocker though.
Thoughts, comments?